Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] window screenx 신규 번역 #25002

Merged
merged 6 commits into from
Dec 21, 2024
Merged

[ko] window screenx 신규 번역 #25002

merged 6 commits into from
Dec 21, 2024

Conversation

givvemee
Copy link
Contributor

Description

기존에 한국어로 존재하지 않던 문서 screenX를 신규 번역합니다.

Motivation

Additional details

Related issues and pull requests

@givvemee givvemee requested a review from a team as a code owner December 11, 2024 11:09
@givvemee givvemee requested review from 1ilsang and removed request for a team December 11, 2024 11:09
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

Preview URLs

Flaws (5)

URL: /ko/docs/Web/API/Window/screenX
Title: Window: screenX property
Flaw count: 5

  • macros:
    • /ko/docs/Web/API/Window/screenLeft does not exist but fell back to /en-US/docs/Web/API/Window/screenLeft
    • /ko/docs/Web/API/Window/screenLeft does not exist but fell back to /en-US/docs/Web/API/Window/screenLeft
    • /ko/docs/Web/API/Window/screenTop does not exist but fell back to /en-US/docs/Web/API/Window/screenTop
    • /ko/docs/Web/API/Window/screenLeft does not exist but fell back to /en-US/docs/Web/API/Window/screenLeft
    • /ko/docs/Web/API/Window/screenY does not exist but fell back to /en-US/docs/Web/API/Window/screenY
External URLs (1)

URL: /ko/docs/Web/API/Window/screenX
Title: Window: screenX property

(comment last updated: 2024-12-21 06:58:20)

1ilsang
1ilsang requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@1ilsang 1ilsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@givvemee 님 안녕하세요. 기여해주셔서 감사합니다! 💯

몇 가지 코멘트 남겨두었습니다.

확인하시고 다시 리뷰 요청 부탁드리겠습니다. 🙇

질문이나 도움이 필요하시다면 언제든 멘션 부탁드리겠습니다.

files/ko/web/api/window/screenx/index.md Outdated Show resolved Hide resolved
files/ko/web/api/window/screenx/index.md Outdated Show resolved Hide resolved
files/ko/web/api/window/screenx/index.md

**`Window.screenX`** 읽기 전용 속성은 사용자의 브라우저 뷰포트의 왼쪽 테두리에서 화면 왼편까지의 수평 거리를 CSS 픽셀 단위로 반환합니다.

> [!NOTE] > `screenX` 의 별칭은 최신 브라우저에
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> [!NOTE] > `screenX` 의 별칭은 최신 브라우저에
> [!NOTE]
> `screenX` 의 별칭은 최신 브라우저에

여기 개행이 안되어있네요.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1ilsang 이걸 개행하면 lint error 가 발생하네요!? 흠 ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bracketSameLine 룰이랑 충돌나는 부분이네요. 이 부분은 따로 수정이 되어야 할 것 같습니다.

PR은 머지하도록 하겠습니다. 고생하셨습니다.

@givvemee @github-actions
Update files/ko/web/api/window/screenx/index.md
4df3a2e 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@givvemee givvemee requested a review from 1ilsang December 21, 2024 06:58
@1ilsang 1ilsang merged commit b30012b into mdn:main Dec 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@1ilsang 1ilsang 1ilsang approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@givvemee @1ilsang